feat(RHINENG-9249): create bifrost toggle #2176

mkholjuraev · 2024-04-15T14:59:18Z

Resolves: https://issues.redhat.com/browse/RHINENG-9249

This creates a new toggle to switch between bootc table view and hybrid inventory tabs. This toggle should only be shown to accounts that has bootc images.

To test:

Run the PR
Open the app with an account that has bootc images (ping me for an account with bootc)
Observe the new toggle is present and by default hybrid tabs are shown
Click on the bootc toggle on the right
Observe that you see a mock bootc table
Open the app with another account that does not have any bootc image
Observe that the toggle is not shown

codecov-commenter · 2024-04-15T15:12:14Z

Codecov Report

Attention: Patch coverage is 89.36170% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 57.40%. Comparing base (6ad8fe0) to head (ef09b32).

Files	Patch %	Lines
src/Utilities/edge.js	33.33%	2 Missing ⚠️
src/routes/InventoryComponents/BifrostTable.js	50.00%	1 Missing ⚠️
...c/routes/InventoryComponents/HybridInventory.cy.js	0.00%	1 Missing ⚠️
src/routes/InventoryComponents/HybridInventory.js	94.11%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2176      +/-   ##
==========================================
+ Coverage   57.26%   57.40%   +0.14%     
==========================================
  Files         199      203       +4     
  Lines        6295     6323      +28     
  Branches     1764     1767       +3     
==========================================
+ Hits         3605     3630      +25     
- Misses       2690     2693       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

computercamplove · 2024-04-16T08:12:57Z

/retest

computercamplove · 2024-04-16T08:43:33Z

@mkholjuraev

for what this feature flag hbi.ui.bifrost - when it was decided to use?
since Systems page require filtering and this filtering works only with "hbi.api.xjoin-disable" is enabled for specific account - account without this feature flag gets 500 and page is not loading, i don't see check for this flag
https://stage.foo.redhat.com:1337/api/inventory/v1/hosts?filter[system_profile][bootc_status][booted][image_digest][is]=not_nil&per_page=1
toggle works as expected in account that has image-mode systems and feature flag "hbi.api.xjoin-disable" is enabled

mkholjuraev · 2024-04-16T08:50:29Z

@computercamplove to your questions:

The frontend has an agreement to put a feature flag in every new feature
I did not know since yesterday evening's meeting about this backend flag. As it is backend-related, should it be used in frontend???
It was said yesterday that this flag was not in prod. I thought the backend getting rid of it, do I understand correctly that

computercamplove · 2024-04-16T09:06:50Z

@computercamplove to your questions:

1. The frontend has an agreement to put a feature flag in every new feature

2. I did not know since yesterday evening's meeting about this backend flag. As it is backend-related, should it be used in frontend???

3. It was said yesterday that this flag was not in prod. I thought the backend getting rid of it, do I understand correctly that

thank you for explanation, i was asking because Bifrost team decided that they don't need UI flag check - user don't have image mode systems so they can't see all UI changes related to Bifrost (for context https://redhat-internal.slack.com/archives/C06EDRT4KB6/p1712666815175369 , https://redhat-internal.slack.com/archives/C02T90PLJ5V/p1711476987847739?thread_ts=1711475282.279549&cid=C02T90PLJ5V). But it's fine to have - in this case we will have enabled in both environments to keep automated tests running. If there will any issue we will disable it in production via your flag.
i guess so, without this flag check filter url is not working on all accounts as you said yesterday (and as Dan explained this filter doesn't work with xjoin and works only when Xjoin is disabled - Xjoin disabled only for specific account, not on whole stage/prod, HBI team still works on migration), if you want we can clarify it again via thread with Chris/Dan.
"hbi.api.xjoin-disabled" is on prod (i just need to add account number to it so we can test it later)

computercamplove · 2024-04-16T13:52:20Z

here clarification
Filtering image-mode systems without Xjoin is expected to be ready by Summit
for context
https://redhat-internal.slack.com/archives/CQFKM031T/p1713273872452199

johnsonm325 · 2024-04-16T18:31:41Z

@mkholjuraev We'll need to handle errors. The api for checking for bootc returned a 500 and the page just loads and never errors

mkholjuraev · 2024-04-18T09:22:10Z

@johnsonm325 it seems this continuous loading is because of this handler that only considers 403 errors. I think this was to solve some issues. @gkarat I am wondering if we can generalise that handler to other error types as well?

gkarat · 2024-04-18T13:56:52Z

@mkholjuraev, yeah, the 403 handler was introduced here #2138, you can also find some details why it was done. You can for sure extend this block and treat other codes if it's necessary.

johnsonm325

I think this looks good enough to approve.

Just fix conflicts and address the small things I've pointed out.

johnsonm325 · 2024-04-18T19:36:04Z

src/routes/InventoryPage.js

+Inventory.defaultProps = {
+  initialLoading: true,
+  notificationProp: PropTypes.object,
+};
+Inventory.propTypes = {
+  isImmutableTabOpen: PropTypes.bool,
+};


Can these be removed?

Good call, will remove them

johnsonm325 · 2024-04-18T19:40:58Z

src/routes/InventoryComponents/InventoryPageHeader.js

+  const isBifrostEnabled = useFeatureFlag('hbi.api.disable-xjoin');
+  const { hasBootcImages } = useContext(AccountStatContext);


Is it worth it to provide isBifrostEnabled via the AccountStatContext as well?

The context is used to hold information about an account. I believe the flag would not be a proper thing to add.

gkarat · 2024-04-19T12:05:28Z

🎉 This PR is included in version 1.68.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mkholjuraev requested a review from a team as a code owner April 15, 2024 14:59

mkholjuraev marked this pull request as draft April 16, 2024 08:57

mkholjuraev marked this pull request as ready for review April 17, 2024 13:06

johnsonm325 approved these changes Apr 18, 2024

View reviewed changes

mkholjuraev added 5 commits April 19, 2024 11:26

feat(RHINENG-9249): create bifrost toggle

9eb8b60

chore: fix tests

0af3374

chore: use the SVG image icon from the mock

92e84f7

chore: use hbi.api.disable-xjoin flag

5a6b686

chore: remove obsolete propType definitions

e86b6ef

mkholjuraev force-pushed the bootc branch from b7a1966 to e86b6ef Compare April 19, 2024 09:36

chore: fix cypress util import link

ef09b32

mkholjuraev merged commit 5fc6d2d into RedHatInsights:master Apr 19, 2024
2 checks passed

gkarat added the released label Apr 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(RHINENG-9249): create bifrost toggle #2176

feat(RHINENG-9249): create bifrost toggle #2176

mkholjuraev commented Apr 15, 2024

codecov-commenter commented Apr 15, 2024 •

edited

Loading

computercamplove commented Apr 16, 2024

computercamplove commented Apr 16, 2024

mkholjuraev commented Apr 16, 2024

computercamplove commented Apr 16, 2024 •

edited

Loading

computercamplove commented Apr 16, 2024

johnsonm325 commented Apr 16, 2024

mkholjuraev commented Apr 18, 2024

gkarat commented Apr 18, 2024

johnsonm325 left a comment

johnsonm325 Apr 18, 2024

mkholjuraev Apr 18, 2024

johnsonm325 Apr 18, 2024

mkholjuraev Apr 18, 2024

gkarat commented Apr 19, 2024

		const isBifrostEnabled = useFeatureFlag('hbi.api.disable-xjoin');
		const { hasBootcImages } = useContext(AccountStatContext);

feat(RHINENG-9249): create bifrost toggle #2176

feat(RHINENG-9249): create bifrost toggle #2176

Conversation

mkholjuraev commented Apr 15, 2024

codecov-commenter commented Apr 15, 2024 • edited Loading

Codecov Report

computercamplove commented Apr 16, 2024

computercamplove commented Apr 16, 2024

mkholjuraev commented Apr 16, 2024

computercamplove commented Apr 16, 2024 • edited Loading

computercamplove commented Apr 16, 2024

johnsonm325 commented Apr 16, 2024

mkholjuraev commented Apr 18, 2024

gkarat commented Apr 18, 2024

johnsonm325 left a comment

Choose a reason for hiding this comment

johnsonm325 Apr 18, 2024

Choose a reason for hiding this comment

mkholjuraev Apr 18, 2024

Choose a reason for hiding this comment

johnsonm325 Apr 18, 2024

Choose a reason for hiding this comment

mkholjuraev Apr 18, 2024

Choose a reason for hiding this comment

gkarat commented Apr 19, 2024

codecov-commenter commented Apr 15, 2024 •

edited

Loading

computercamplove commented Apr 16, 2024 •

edited

Loading